search

datalad / datalad-usage-dashboard

Dashboard of detected usages of DataLad
MIT License
4 stars 2 forks source link

not unmark as a dataset or "run" if was known to be such before #14

Closed yarikoptic closed 3 years ago

yarikoptic commented 3 years ago

just spotted in the most recent https://github.com/datalad/datalad-usage-dashboard/commit/38bfc1afc6e5bc8f107617e5cbcf6a3967e99359 that they got unmarked as no longer a dataset.

So I guess altogether with #9, it is just that github search might not return some hits, although they are still "valid". Ideally there should be a time stamp for every "category" but I think it is ok to just not reset them if ever set -- I would not expect much of git hard --reset or alike which would make a prior hit no longer valid. We will leave to https://github.com/datalad/datalad-registry to discover all gory details and keep them up to date.

yarikoptic commented 3 years ago

I spotted datasets being unassigned, e.g. https://github.com/datalad/datalad-usage-dashboard/commit/9dd8de6c8acfcb17b5592cefde2791e206b00c5b#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R72 . Let's not unassign, even if without a time stamp to check when last seen as one.