search

datalad / datalad-xnat

Track XNAT projects with DataLad
Other
3 stars 9 forks source link

Properly save subdatasets too #109

Closed mih closed 2 years ago

mih commented 2 years ago

Leave the saving to addurls instead of doing it outside. addurls knows precisely what needs saving, and the save the outside, possibly expensive, status call that is implied by save.

Fixes datalad/datalad-xnat#108

codecov-commenter commented 2 years ago

Codecov Report

Merging #109 (ee5991e) into master (2d873d8) will decrease coverage by 0.04%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   85.67%   85.63%   -0.05%     
==========================================
  Files          11       11              
  Lines         342      341       -1     
==========================================
- Hits          293      292       -1     
  Misses         49       49
Impacted Files Coverage Δ
datalad_xnat/tests/test_xnatcentral.py 100.00% <ø> (ø)
datalad_xnat/update.py 86.48% <ø> (-0.19%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2d873d8...ee5991e. Read the comment docs.