Seemingly unused parameter in platform _XNAT

datalad / datalad-xnat

Track XNAT projects with DataLad

Other

3 stars 9 forks source link

Seemingly unused parameter in platform _XNAT #144

Closed mslw closed 2 years ago

mslw commented 2 years ago

At first glance, the platform._XNAT class has a cmd_param named collection which is not referenced at all within the class definition (or the file which defines it). Is it a holdover from a previous approach, preparation for something to be done, or something which is used elsewhere? Alternatively, I could have just missed something.

https://github.com/datalad/datalad-xnat/blob/16f30ab0e36d5a055f01c0cc5ed36d3d70a05a59/datalad_xnat/platform.py#L89-L96

welcome[bot] commented 2 years ago

Welcome Banner (Image: CC-BY license, The Turing Way Community, & Scriberia. Zenodo. http://doi.org/10.5281/zenodo.3332808) Hi there, and welcome to the DataLad XNAT Extension! :orange_book: :wave: Thank you for filing an issue. We're excited to have your input and welcome your idea! :blush: If you haven't done so already, please make sure you check out our Code of Conduct.

mih commented 2 years ago

I am closing this issue, because all these args are used in init and update. This class is just the place where they presently live.

I guess a comment could be added.