mih commented 2 years ago

Towards datalad/datalad-xnat#6 and gets us close to 80% test coverage already.

mih commented 2 years ago

Windows test failure

[{'action': 'addurls',
474  'exception': Unknown placeholder 'url' in URL:  [addurls.py:__call__:1374,addurls.py:extract:796,addurls.py:extract:794,addurls.py:format:92,string.py:format:161,string.py:vformat:165,string.py:_vformat:205,string.py:get_field:270,addurls.py:get_value:112,string.py:get_value:227],
475  'message': "ValueError(Unknown placeholder 'url' in URL: )",
476  'path': 'C:\\DLTMP\\datalad_temp_unvxkqso',
477  'status': 'error',
478  'type': 'dataset'}]

replicates locally. Looks like a POSIX path separator issue

codecov-commenter commented 2 years ago

Codecov Report

Merging #31 (c0a233a) into master (0d59468) will increase coverage by 47.28%. The diff coverage is 92.30%.

@@             Coverage Diff             @@
##           master      #31       +/-   ##
===========================================
+ Coverage   34.03%   81.31%   +47.28%     
===========================================
  Files           7        8        +1     
  Lines         191      198        +7     
===========================================
+ Hits           65      161       +96     
+ Misses        126       37       -89

Impacted Files	Coverage Δ
datalad_xnat/init.py	`76.00% <ø> (+36.78%)`	:arrow_up:
datalad_xnat/parser.py	`89.28% <66.66%> (+89.28%)`	:arrow_up:
datalad_xnat/tests/test_xnatcentral.py	`100.00% <100.00%> (ø)`
datalad_xnat/update.py	`82.85% <100.00%> (+48.57%)`	:arrow_up:
datalad_xnat/platform.py	`66.66% <0.00%> (+33.33%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0d59468...c0a233a. Read the comment docs.

mih commented 2 years ago

Tests pass. Basic functionality working uniformly across all platforms.

datalad / datalad-xnat

First minimal integration test #31

Codecov Report