search

datalad / datalad.org

Website sources of datalad.org
https://www.datalad.org
4 stars 10 forks source link

ENH(BK): Add youtube channel icon/link by the twitter #52

Closed yarikoptic closed 5 years ago

yarikoptic commented 5 years ago

Closes #37

TODOs:

@aqw please finish it up

aqw commented 5 years ago

@yarikoptic I have updated the fontello font, but I can't push to your branch. What is your preferred workflow? Do you want me to PR your PR? Do you want to grant me permissions? Push my own commit to master after merging yours?

Let me know. :-)

---Alex

Also, as FYI for updating fontello, I just simply do a manual process (though there are programmatic methods, I've just never bothered yet). 1) go to fontello.com 2) "import" the config.json file in theme/static/fonts/ 3) search and add whatever glyph is needed 4) download and extract 5) overwrite fontello.woff, fontello.woff2, and config.json 6) port the added rule(s) from css/fontello.css to style.css

yarikoptic commented 5 years ago

ontello font, but I can't push to your branch

Strange... You should be able to ... Sorry for seemingly silly question - did you try?

aqw commented 5 years ago 
╭─aqw@brick ~/git/www.datalad.org on yarikoptic-enh-youtube
╰─➤ git push yarikoptic yarikoptic-enh-youtube
Enumerating objects: 19, done.
Counting objects: 100% (19/19), done.
Delta compression using up to 4 threads
Compressing objects: 100% (9/9), done.
Writing objects: 100% (10/10), 11.04 KiB | 5.52 MiB/s, done.
Total 10 (delta 4), reused 0 (delta 0)
remote: Resolving deltas: 100% (4/4), completed with 4 local objects.
To github.com:yarikoptic/datalad.org
 ! [remote rejected] yarikoptic-enh-youtube -> yarikoptic-enh-youtube (permission denied)
error: failed to push some refs to 'git@github.com:yarikoptic/datalad.org'

╭─aqw@brick ~/git/www.datalad.org on yarikoptic-enh-youtube
╰─➤ git remote show yarikoptic
* remote yarikoptic
  Fetch URL: git@github.com:yarikoptic/datalad.org
  Push  URL: git@github.com:yarikoptic/datalad.org
  HEAD branch: master
  Remote branches:
    enh-datasets tracked
    enh-heudi    tracked
    enh-index    tracked
    enh-search   tracked
    enh-widen    tracked
    enh-youtube  new (next fetch will store in remotes/yarikoptic)
    master       tracked
    nitpicking   tracked
  Local ref configured for 'git push':
    master pushes to master (fast-forwardable)
aqw commented 5 years ago

FML. And now I see it. Sigh....

I was trying to push to the yarikoptic-enh-youtube branch, and in fact should have been pushing to enh-youtube.

Sorry about the noise. It's pushed now.

---Alex

edit: formatting

aqw commented 5 years ago

Ok. Build passes. Merging.

yarikoptic commented 5 years ago

Thanks! sorry I've missed initial troubleshooting email, glad to see you figure it out.