search

datalad / git-annex

A non-official clone of git-annex established for DataLad purposes. No PRs will be merged, but could be used to test perspective git-annex patches. Official git-annex repository: https://git.kitenet.net/index.cgi/git-annex.git/
16 stars 3 forks source link

Fix compilation error on Windows/all in commit 44d763468 #134

Closed jkniiv closed 1 year ago

jkniiv commented 1 year ago

Quick fix -- feel free to ignore. I'm not a developer (just a hobbyist with systems specialist background) and this is my first pull request for someone else's project. Hope the patch is of use if @joeyh doesn't have time to fix it at his end.

jkniiv commented 1 year ago

Fascinating. Ok, I haven't had much interaction with CI before, so this is new to me. However, it looks like the Ubuntu build is failing @ phase "Import GPG keys" due to causes unrelated to the source code. Something to do with a GPG key and so called "secrets" where it should be derived from. I guess I don't have those "secrets" set up for me. 😄

yarikoptic commented 1 year ago

However, it looks like the Ubuntu build is failing @ phase "Import GPG keys" due to causes unrelated to the source code.

THANK YOU @jkniiv -- it is failing because indeeds needs GPG keys which would only be available whenever PR is submitted from a branch in this repo... that key is then to be used by dpkg-buildpackage so that .dsc and .changes files (which we do include in the release) carry signature... but I do not think we need that for PRs and it would be just fine to not sign. I will quickly check by pigging backing on your PR ;)

yarikoptic commented 1 year ago

ok, no fix upstream, so let's have it fixed, thanks again @jkniiv !