datalad / git-annex

A non-official clone of git-annex established for DataLad purposes. No PRs will be merged, but could be used to test perspective git-annex patches. Official git-annex repository: https://git.kitenet.net/index.cgi/git-annex.git/
16 stars 3 forks source link

dynamically load client ids in the workflow instead of needing to template out #151

Closed yarikoptic closed 1 year ago

yarikoptic commented 1 year ago

ATM

❯ git grep openmind
.github/workflows/build-ubuntu.yaml:          for clientid in ndoli smaug openmind7
clients/clients.yaml:openmind7:

due to

.github/workflows/template/build-{{ostype}}.yaml.j2:          for clientid in {{clients|join(" ")}}

and that is the only thing which gets templated after adding a new client (see e.g. https://github.com/datalad/git-annex/commit/f870173cc79a0d433d3c37cf4bf4835606017e3c). To avoid that step, which requires local setup of venv which is otherwise not needed for anything, the workflow itself could easily load it out from clients.yaml which it has in local checkout. That would simplify addition of a new client or removal of an old one