windows build failed for a release

[yarikoptic]

attn @joeyh. Windows builds did experience some issues recently here and on appveyor AFAIK. Here we got no .exe installer for the 10.20230802 release and most recent windows build (not sure if for release, didn't check) errored https://github.com/datalad/git-annex/actions/runs/5746300684/job/15575557523#step:18:381 with

[ 90 of 687] Compiling Utility.LockFile.Windows

D:\a\git-annex\git-annex\Utility\LockFile\Windows.hs:70:17: error: [GHC-88464]
Error:     Variable not in scope:
      c_CreateFile
        :: LPTSTR
           -> AccessMode
           -> ShareMode
           -> GHC.Ptr.Ptr a0
           -> CreateMode
           -> FileAttributeOrFlag
           -> GHC.Ptr.Ptr a1
           -> IO HANDLE
    Suggested fix:
      Perhaps use `createFile' (imported from System.Win32.File)
   |
70 |                 c_CreateFile c_f gENERIC_READ sharemode security_attributes
   |                 ^^^^^^^^^^^^
[ 96 of 687] Compiling Utility.Path.Tests
....
Error: [S-7282]
       Stack failed to execute the build plan.

       While executing the build plan, Stack encountered the error:

       [S-7011]
       While building package git-annex-10.20230802 (scroll up to its section to see the error)
       using:
       D:\a\git-annex\git-annex\.stack-work\dist\01de9cfc\setup\setup --verbose=1 --builddir=.stack-work\dist\01de9cfc build exe:git-annex --ghc-options ""
       Process exited with code: ExitFailure 1 
Error: Process completed with exit code 1.

historical record from emails:

 592   T Aug 02 GitHub Actions  *-2.3* ( 14K/0) datalad/git-annex daily summary: 29 PASSED, 12 FAILED, 12 INCOMPLETE                                                                                                                                               
 909   T Aug 01 GitHub Actions  *-1.9* (7.4K/0) datalad/git-annex daily summary: 32 PASSED                                                                                                                                                                         
1223   T Jul 31 GitHub Actions  *-2.8* (7.5K/0) datalad/git-annex daily summary: 30 PASSED, 2 FAILED                                                                                                                                                               
1528   T Jul 30 GitHub Actions  *-3.6* (7.4K/0) datalad/git-annex daily summary: 32 PASSED                                                                                                                                                                         
1703   T Jul 29 GitHub Actions  *-1.5* (7.4K/0) datalad/git-annex daily summary: 31 PASSED, 1 FAILED                                                                                                                                                               
1907   T Jul 28 GitHub Actions  *-1.6* (7.4K/0) datalad/git-annex daily summary: 32 PASSED               

edit: HTML of the most recent report is at https://github.com/datalad/git-annex-ci-reports/blob/master/2023/08/02.html which can be seen at https://datalad.github.io/git-annex-ci-reports/2023/08/02.html

[joeyh]

This is fixed in git-annex since Wednesday. But, my fix involved changing the build procedure on Windows for now. stack has to be told to build with stack-lts-18.13.yaml rather than the default stack.yaml. eg with the --stack-yaml parameter.

-- see shy jo

[yarikoptic]

do you mean adding --stack-yaml to this place in our build instructions?

https://github.com/datalad/git-annex/blob/master/.github/workflows/build-windows.yaml#L134

[yarikoptic]

windows builds seems to be ok now, osx are not (#170)