search

datalad / git-annex

A non-official clone of git-annex established for DataLad purposes. No PRs will be merged, but could be used to test perspective git-annex patches. Official git-annex repository: https://git.kitenet.net/index.cgi/git-annex.git/
14 stars 3 forks source link

TEMP: testing if adding --stack-yaml addresses build fail on windows #169

Closed yarikoptic closed 11 months ago

yarikoptic commented 11 months ago

ref: https://github.com/datalad/git-annex/issues/168

jkniiv commented 11 months ago

For best effect I think you need to address the following lines as well with the added --stack-yaml option or the proper stack.yaml file:

Basically wherever there is stack it should be replaced with stack --stack-yaml stack-lts-18.13.yaml because with Haskell Stack the whole build environment is ultimately defined by the stack.yaml. For my personal Windows builds I use a Justfile (just is a modern make-like utility) and there I defined a (template-style) variable called stack-cmd which is now effectively the same as stack --stack-yaml stack-lts-18.13.yaml (actually it takes the option from an environment variable but that's just an small detail). So I replaced all invocations of stack with {{ stack-cmd }} and that produced a working binary from version 10.20230802 sources via {{ stack-cmd }} setup && {{ stack-cmd }} build. Maybe something similar can be done here with the github workflow definition?

yarikoptic commented 11 months ago

Thank you @jkniiv ! Sounds sensible. But as I think this is all temporary (right @joeyh ) let me try other approach -- just rename the damn config file into stack.yaml and be done ;)

yarikoptic commented 11 months ago

ok, that simple way worked, I will stick to it for now

yarikoptic commented 11 months ago

I do not expect surprises, so will merge