search

datalad / git-annex

A non-official clone of git-annex established for DataLad purposes. No PRs will be merged, but could be used to test perspective git-annex patches. Official git-annex repository: https://git.kitenet.net/index.cgi/git-annex.git/
14 stars 3 forks source link

mac builds fail datalad tests #170

Closed yarikoptic closed 11 months ago

yarikoptic commented 11 months ago

started to happen recently - no good build for 5 days

e.g.

FAILED ../datalad/tests/test_utils_testrepos.py::test_BasicAnnexTestRepo_random_location_generated - datalad.runner.exception.CommandError: CommandError: 'git -c diff.ignoreSubmodules=none -c core.quotepath=false annex addurl --file=test-annex.dat http://127.0.0.1:49418//testrepo-annex.dat --json --json-error-messages --json-progress -c annex.dotfiles=true' failed with exitcode 1 under /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/datalad_temp_testrepo_vv3pvgeb [info keys: stdout_json]
>download failed [err: 'dyld: Library not loaded: @loader_path/../../../../opt/openldap/lib/libldap.2.dylib
  Referenced from: /Applications/git-annex.app/Contents/MacOS/bundle/curl
  Reason: image not found
dyld: Library not loaded: @loader_path/../../../../opt/openldap/lib/libldap.2.dylib
  Referenced from: /Applications/git-annex.app/Contents/MacOS/bundle/curl
  Reason: image not found
addurl: 1 failed']
FAILED ../datalad/tests/test_utils_testrepos.py::test_BasicAnnexTestRepo - datalad.runner.exception.CommandError: CommandError: 'git -c diff.ignoreSubmodules=none -c core.quotepath=false annex addurl --file=test-annex.dat http://127.0.0.1:49418//testrepo-annex.dat --json --json-error-messages --json-progress -c annex.dotfiles=true' failed with exitcode 1 under /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/datalad_temp_test_BasicAnnexTestRepo2o4d_rn8 [info keys: stdout_json]
>download failed [err: 'dyld: Library not loaded: @loader_path/../../../../opt/openldap/lib/libldap.2.dylib
  Referenced from: /Applications/git-annex.app/Contents/MacOS/bundle/curl
  Reason: image not found
dyld: Library not loaded: @loader_path/../../../../opt/openldap/lib/libldap.2.dylib
  Referenced from: /Applications/git-annex.app/Contents/MacOS/bundle/curl
  Reason: image not found
addurl: 1 failed']
= 41 failed, 1125 passed, 114 skipped, 2 xfailed, 1 xpassed, 18 warnings in 5594.29s (1:33:14) =

@joeyh anything immediate comes to mind?

joeyh commented 11 months ago

Looks like curl has been changed to link to libldap. Looking at the curl binary in the last successful dmg build, it does not link to that.

And the use of @loader_path prevents it from including libldap into the .dmg.

I've made git-annex stop bundling curl in the dmg. Which should avoid this problem. Although if you're testing git-annex in a way that needs curl, you'll need to install curl if it's not already installed.. The git-annex addurl command that failed doesn't normally use curl, so I assume you are setting annex.web-options in git config or something..

yarikoptic commented 11 months ago

Thanks for looking into it! Let's see how the next build is feeling!

so I assume you are setting annex.web-options in git config or something..

I will look into what that something is since we do not use annex.web-options AFAIK if the next round errors out too.

yarikoptic commented 11 months ago

seems to be ok now