Open yarikoptic opened 3 years ago
any immediate ideas on what is going wrong here? given that master
soon will be released as 0.14.0 and thus maint
jump over to current master
, may be this issue would disappear on its own though
@yarikoptic I do not know what's going wrong. Further ad hoc customization of the SSH setup scripts would be needed in order to get any debugging information.
Ah, let's then forget about it and wait for master release
actually I take it back since I mixed it all up -- it works only on release and not on maint or master, so we are doomed to pin it down :-/ FWIW it seems failing differently ATM
so I guess it boils down to how datalad is installed (from pypi vs straight from git)?
@yarikoptic Those errors are occurring before datalad is even installed. We've also known about the maint issue for a while, and it continues to fail despite doing what the docker-machine docs say.
d'oh -- looked into our template:
{% if ostype == "ubuntu" or ostype == "macos" %}
- name: Set up SSH target
shell: bash
# TODO: Drop the release condition once 0.13.2 is released.
run: |
if [ "${{ matrix.version }}" != "release" ]; then
{% if ostype == "macos" %}
that explains the difference between released or not. On released (which we should have started to test against SSH) we do not even bother to set it up for running SSH tests. So, at least that mystery is not a mystery ;) I will submit a PR now to just disable setting it up for SSH on OSX, so we get green again, but we still need to figure out WTF we fail to establish that docker container on OSX.
@yarikoptic I believe I've finally fixed this. The problem was that SSH was configured to connect to localhost, but when using docker-machine, containers' ports aren't exposed on localhost, they're exposed on the IP address for the docker-machine VM.
PRs: https://github.com/datalad/datalad/pull/5417, https://github.com/datalad/git-annex/pull/55
AWESOME, Thank you @jwodder !
Eventually we should get back to this , and either finish #55 or #58 but currently testing against datalad is still red overall since recent annex changes caused breakages, see https://github.com/datalad/datalad/issues/6492 -- so we are pretty much blocked by that. We should get back to adding ssh testing as soon as datalad turns green again here.
see e.g. https://github.com/datalad/git-annex/actions/runs/458535490 runs
did not look inside on how to resolve but must be possible one way or another (may be it is just a port conflict issue among multiple docker instances on the same box?)