datalad / git-annex

A non-official clone of git-annex established for DataLad purposes. No PRs will be merged, but could be used to test perspective git-annex patches. Official git-annex repository: https://git.kitenet.net/index.cgi/git-annex.git/
16 stars 3 forks source link

Use docker-practice/actions-setup-docker to set up Docker on macOS #58

Closed jwodder closed 2 years ago

jwodder commented 3 years ago

This is an alternative to #55.

yarikoptic commented 3 years ago

it somehow wasn't in effect? I still see /Users/runner/DLTMP ... needs debugging. BTW -- does it replicate on your OSX laptop (trying to ssh into that docker container etc)?

jwodder commented 3 years ago

@yarikoptic I forgot to run make after updating the template for the previous commit. That's fixed now.

yarikoptic commented 3 years ago

now it is red across all CI runs for test-datalad, I guess more work todo

jwodder commented 3 years ago

@yarikoptic Datalad seems to be resolving TMPDIR on the host machine and then using that path inside the Docker container, which leads to failures, as /tmp on macOS is a symlink to /private/tmp, which doesn't exist inside the containers and which Datalad doesn't have permission to create.

yarikoptic commented 3 years ago

re ubuntu fails -- would be worth rerunning, I think the issue with test_expanduser failing was identified/resolved.

re OSX: I guess we should bind mount resolved /tmp (/private/tmp?) as well to resolve it?

jwodder commented 2 years ago

Closing as the action in question does not seem to work properly any more.