search

datalad / git-annex

A non-official clone of git-annex established for DataLad purposes. No PRs will be merged, but could be used to test perspective git-annex patches. Official git-annex repository: https://git.kitenet.net/index.cgi/git-annex.git/
16 stars 3 forks source link

datalad: should have "full install" due to versioneer (or smth to fix in versioneer) #71

Closed yarikoptic closed 3 years ago

yarikoptic commented 3 years ago

stroke me that most likely both https://github.com/datalad/datalad/issues/5785 are due to what I did observe now in the logs for datalad wtf output:

2021-07-07T02:53:57.0382856Z ## datalad
2021-07-07T02:53:57.0383415Z   - full_version: 0+unknown
2021-07-07T02:53:57.0384390Z   - version: 0+unknown

and we are doing pip install https://github.com/datalad/datalad/archive/${commitish}.zip ... may be pip install git+https://... or some other way would provide a versioneer-friendly installation. I am also confused why /archive/ is not really a git-archive output here since AFAIK versioneer should have populated the $placeholders in datalad/_version.py during git archive ... may be something to fix in versioner?

jwodder commented 3 years ago

The placeholders are populated. The problem is that, unless you're installing from an archive of a tag, Git's $Format$ placeholders simply don't provide enough information to determine a version, so versioneer has no choice but to fail. The solution is to install from a full Git clone instead, i.e., pip install git+https://github.com/datalad/datalad@${commitish}.

yarikoptic commented 3 years ago

Thank you did the analysis. Let's do that git+ URLs then