datalad / git-annex

A non-official clone of git-annex established for DataLad purposes. No PRs will be merged, but could be used to test perspective git-annex patches. Official git-annex repository: https://git.kitenet.net/index.cgi/git-annex.git/
17 stars 3 forks source link

linux: make it build with newer git (currently 2.24.0) #88

Closed yarikoptic closed 3 years ago

yarikoptic commented 3 years ago

I guess that is what ubuntu-latest has and thus it gets bundled within git-annex standalone package build. Spotted while seeing fails of tests in https://github.com/datalad/datalad-extensions/runs/3751357707?check_suite_focus=true against "latest and greatest git-annex" that git init lacked -b option (to initialize into the named branch).

Even Debian stable (https://packages.debian.org/search?keywords=git) has 2.30.2-1 .

jwodder commented 3 years ago

@yarikoptic I suspect this is due to the singularity image (shub://datalad/datalad-extensions:buildenv-git-annex-buster) used to build git-annex for Linux being out of date. Note that the -b option to git init was introduced in Git 2.28.

yarikoptic commented 3 years ago

Oh, I forgot our kitchen here... Given that shub is now readonly I guess we need to establish some alternative build/deployment for that container...

yarikoptic commented 3 years ago

based on that https://github.com/datalad/datalad-extensions/blob/master/containers/Singularity.buildenv-git-annex-buster please setup building (github action, to react on changes to Dockerfile) and pushing to dockerhub.

jwodder commented 3 years ago

@yarikoptic Is DOCKER_TOKEN supposed to be a password for the "yarikoptic" user? When I try to push with it, I get "requested access to the resource is denied".

yarikoptic commented 3 years ago

No, it is a token (not password), likely for yarikoptic user. May be that one lacks permission... I will look into it shortly

jwodder commented 3 years ago

@yarikoptic I don't see a way to use just a token with the Docker CLI.

yarikoptic commented 3 years ago

I think token should be used as password but likely yarikoptic has no authority to push to that organization... I will check

yarikoptic commented 3 years ago

uff... I can login (testing locally) with token just fine and when you generate a token it says image (I have removed this one so should be safe). But whenever I try to push anything even to my account or datalad organization (where I added us both as owners), it indeed fails:

(git-annex)lena:~datalad/ansi[master]
$> docker push yarikoptic/squeeze
Using default tag: latest
The push refers to repository [docker.io/yarikoptic/squeeze]
5f70bf18a086: Preparing 
085be35d9b38: Preparing 
denied: requested access to the resource is denied
(dev3) 1 18401 ->1 [1].....................................:Tue 05 Oct 2021 10:07:03 AM EDT:.
(git-annex)lena:~datalad/ansi[master]
$> docker tag debian:squeeze squeeze:latest           
(dev3) 1 18402 [1].....................................:Tue 05 Oct 2021 10:07:10 AM EDT:.
(git-annex)lena:~datalad/ansi[master]
$> docker push squeeze                     
Using default tag: latest
The push refers to repository [docker.io/library/squeeze]
5f70bf18a086: Preparing 
085be35d9b38: Preparing 
denied: requested access to the resource is denied
(dev3) 1 18403 ->1 [1].....................................:Tue 05 Oct 2021 10:07:14 AM EDT:.
(git-annex)lena:~datalad/ansi[master]
$> docker tag debian:squeeze datalad/squeeze:latest
(dev3) 1 18404 [1].....................................:Tue 05 Oct 2021 10:07:57 AM EDT:.
(git-annex)lena:~datalad/ansi[master]
$> docker push datalad/squeeze   
Using default tag: latest
The push refers to repository [docker.io/datalad/squeeze]
5f70bf18a086: Preparing 
085be35d9b38: Preparing 
denied: requested access to the resource is denied

uff... as noted above, I have added you to datalad organization, so we might just push under that one. Please try to figure it out