search

datalad / git-annex

A non-official clone of git-annex established for DataLad purposes. No PRs will be merged, but could be used to test perspective git-annex patches. Official git-annex repository: https://git.kitenet.net/index.cgi/git-annex.git/
17 stars 3 forks source link

Add invocation of datalad's tools/ci/deploy_datalad-rootca on Ubuntu #97

Closed yarikoptic closed 2 years ago

yarikoptic commented 2 years ago

master branch of datalad now goes extra mile to enable testing for https urls, and requires running tools/ci/deploy_datalad-rootca script (has sudo inside already, not distributed with pip installed copy of datalad). If that is not done -- test should gracefully skip.

I thought that adding call out to that script should resolve current build failure on ubuntu against master which I saw with some related errors (but now failing to find -- may be they were not that critical actual). Recent build succeeded (https://github.com/datalad/git-annex/actions/runs/1649581476) so I guess it was not the issue exactly, and there is no urgency to have this done , but we better have those tests enabled here on CI.

Note: that script will not be present in maint branch but setting it using code/version from master branch (i.e. not bother doing it only for master and then needing to add later after 0.16.0 release for everything else) of datalad should not have negative effects AFAIK on tests against release/maint, but I could be proven wrong.

jwodder commented 2 years ago

@yarikoptic The script in question requires a file from datalad/tests/ca/, but this directory is not included when datalad is installed. I mentioned this before; should it be installed?

yarikoptic commented 2 years ago

Just shallow clone entire datalad repo to get all files?

Please submit a separate PR with the fix for shipping those needed files.

jwodder commented 2 years ago

@yarikoptic PR submitted: https://github.com/datalad/datalad/pull/6336