search

datalayer / jupyter-server-nbmodel

Jupyter Server NbModel
BSD 3-Clause "New" or "Revised" License
12 stars 2 forks source link

Does not show outputs with JupyterLab 4.3.0b0 #26

Open krassowski opened 1 month ago

krassowski commented 1 month ago

Description

Not sure where the contract is broken, probably on JupyterLab side but just as a heads up the outputs do not show up, an exception is thrown:

TypeError: e.toJSON is not a function
    at jlab_core.abd83dd7cfacd6da4d00.js?v=abd83dd7cfacd6da4d00:1:238328
    at 1168.8e5df3139aa020a611cb.js?v=8e5df3139aa020a611cb:1:551
    at q._onSharedModelChanged (jlab_core.abd83dd7cfacd6da4d00.js?v=abd83dd7cfacd6da4d00:1:238119)
    at m (jlab_core.abd83dd7cfacd6da4d00.js?v=abd83dd7cfacd6da4d00:1:1838868)
    at Object.l [as emit] (jlab_core.abd83dd7cfacd6da4d00.js?v=abd83dd7cfacd6da4d00:1:1838544)
    at a.emit (jlab_core.abd83dd7cfacd6da4d00.js?v=abd83dd7cfacd6da4d00:1:1836381)
    at Array._modelObserver (1168.8e5df3139aa020a611cb.js?v=8e5df3139aa020a611cb:1:7524)
    at Object.r (383.db345dbeef5ef774e50c.js?v=db345dbeef5ef774e50c:1:936)
    at ji (383.db345dbeef5ef774e50c.js?v=db345dbeef5ef774e50c:1:43499)
    at Array.<anonymous> (383.db345dbeef5ef774e50c.js?v=db345dbeef5ef774e50c:1:52559)

Reproduce

Expected behavior

2

Context

krassowski commented 1 month ago

It looks like we've got quite some work to do here:

https://github.com/datalayer/jupyter-server-nbmodel/blob/0a6c6830cfd08dd370d0aeffa8052aae005cd734/jupyter_server_nbmodel/handlers.py#L140-L174