search

dataliterate / data-populator

A plugin for Sketch and Adobe XD to populate your design mockups with meaningful data. Goodbye Lorem Ipsum. Hello JSON.
MIT License
1.67k stars 113 forks source link

v1.6-beta.2: Text Substitutes don't work as expected in symbols #58

Closed nitrada closed 8 years ago

nitrada commented 8 years ago

when using Text Placeholders a la {placeholder?} that should be substituted with the default substitute, Sketch 3.7.1 crashes when using the "missing-data" Preset that comes with the demo.

nitrada commented 8 years ago

here's a test file – try populating the "item two" symbol with the "missing-data" preset that comes with the demo. re-populate until you run into an empty field.

datapop new symbols.sketch.zip

@lukasondrej does it crash on your setup as well?

lukasondre commented 8 years ago

@nitrada in my testing, substitutes worked without any issues however I've found another issue with missing/invalid image URLs when populating symbols. This could be the cause of the crashes - fixed in the latest commit.

nitrada commented 8 years ago

@lukasondrej will check.

nitrada commented 8 years ago

@lukasondrej seems to work now. the text formating behavior is a bit strange still, will go into detail sometime later. https://github.com/preciousforever/sketch-data-populator/releases/tag/v1.6-beta.3