Fit images in shapes (Feature request)

dataliterate / data-populator

A plugin for Sketch and Adobe XD to populate your design mockups with meaningful data. Goodbye Lorem Ipsum. Hello JSON.

MIT License

1.67k stars 113 forks source link

Closed vladmoroz closed 7 years ago

vladmoroz commented 7 years ago

Would be great to have a checkbox to set image pattern fill type to Fit instead of Fill

nitrada commented 7 years ago

@vladmoroz as a conditional action, you mean? meaning you can change this setting driven by data?

vladmoroz commented 7 years ago

Just a simple setting like this

Alternatively, would be great if plugin would respect layer's pattern fill type and not overwrite it

nitrada commented 7 years ago

respect layer's pattern fill type and not overwrite it

that's something we could do, right @lukasondrej? (i think when we implemented it back then there were no options for the fill)

shannon-murdoch-webjet commented 7 years ago

Maybe a layer name based approach would be better... ie {imgURL | fill} or {imgURL | fit}

rezaarkan commented 7 years ago

Alternatively, would be great if plugin would respect layer's pattern fill type and not overwrite it

Pull request for temporary disable on #78, as suggested by @vladmoroz

nitrada commented 7 years ago

thanks @rezaarkan @vladmoroz @shannon-murdoch-webjet!