datalogic / react-native-datalogic-module

React Native Datalogic Module for Datalogic Android devices
5 stars 6 forks source link

Why so many dependencies? #1

Closed mgroeneweg closed 2 years ago

mgroeneweg commented 3 years ago

Hi,

I really like the library, works great and quick to implement.

However, packaging it is something completely different. Why does it have so many dependencies? Is there any chance some may actually be devdependencies? I end up with over 29.000 objects in 850 packages after adding the library.

Thanks in advance.

mgroeneweg commented 3 years ago

To follow up on this, I created a fork in which I removed all prod dependencies. Our usecase runs just fine and builds a lot faster too.

Please cleanup the dependencies.

codybrookshear commented 3 years ago

Hi @mgroeneweg,

I suspect you are correct, that there is no good reason for us to have so many dependencies. I will put this request in our internal tracker and eliminate all possible dependencies. I'll post an update here when complete.

Thanks for your feedback, Cody

mgroeneweg commented 3 years ago

Hi @codybrookshear,

Thanks! I will update our app as soon as the update is available.

With regards,

Marcel

mgroeneweg commented 2 years ago

Hi @codybrookshear Any news on this?

jonahgeorge commented 2 years ago

Here's the result of running npx depcheck on the repo: depcheck.log

mgroeneweg commented 2 years ago

Indeed! I use a fork in which I cleared the dependencies in package.json. Only the devDependencies and it works just fine.

jmmcconnell commented 2 years ago

@mgroeneweg Given our current priorities, this will likely addressed late in the year.

mgroeneweg commented 2 years ago

Pity. It is such a small change. Late this year could mean the issue is left dangling for a year. That does not look good for our customers who buy your scanners!

sethjray commented 2 years ago

Removed unused dependencies with latest overhaul update

mgroeneweg commented 2 years ago

Great! I will ask the team to ask the new version with their scanners.