search

dataloop-ai / components

Dataloop's component library
Apache License 2.0
3 stars 15 forks source link

[BUG] {{ DL Smart Search }} - Different behavior after a click #780

Open MatanEden7 opened 10 months ago

MatanEden7 commented 10 months ago

Scenario:

Clicking the smart search should open the suggestions

Clicking again will close the suggestions

Clicking the outline will open the suggestions

Clicking the outline again

Actual: Should close the suggestions

Expected: Opening the suggestions

Video: https://share.zight.com/Z4u2d40x

Link: https://rc-staging.dataloop.ai/projects/99d634a1-89bf-4d69-b201-807a29140c76/services/655b3597dec9e63d4312bb10?tab=triggers

Ticket - https://dataloop.atlassian.net/browse/DAT-57887

makc-dataloop commented 5 months ago

@guyDataloop @fadiDL currently smart search emits update:model-value on blur - so should we do the same in the context of this ticket, or just undo the focus? and if it's latter - what if the user already typed something before 2nd click?

fadiDL commented 5 months ago

@makc-dataloop i believe we should blur (with emitting update to the model value). This specific scenario should not behave differently than the normal scenario we have which would handle this case as blurring.

Try to keep the two behaviors of clicking on the outline and clicking in the input the same