search

datalorax / sds-r

Repo for a draft book on social data science methods with R
https://sds.pub
Creative Commons Attribution 4.0 International
9 stars 4 forks source link

Full FE chapter and style changes #11

Closed datalorax closed 3 years ago

datalorax commented 3 years ago

Thought I was missing a package or two in the DESCRIPTION file but it all built without a problem.

This is a first full draft. It needs some cleaning up, I'm sure.

It also includes the style changes we talked about on Slack. I think the actual CSS file could be cleaned up a bit. Mostly with renaming the variables. Like, it would be good to have a "main-color" and "main-accent" (which would be the dark green and the lighter green, probs). But I think it's good enough for now and we can do that later in another PR.

datalorax commented 3 years ago

@brendanhcullen just tagging you here as an FYI that I'm going to go ahead and merge this in. You are free to do whatever style edits you want from here. Let me know if you want to chat about any of them.

brendanhcullen commented 3 years ago

Thanks @datalorax! Excited to read through it. I'll do my review through a separate PR. Maybe at our next team meeting we can narrow down a good Github workflow for reviews/feedback/code commenting. I'm new to that sort of thing but would love to learn best practices.