search

datalorax / sds-r

Repo for a draft book on social data science methods with R
https://sds.pub
Creative Commons Attribution 4.0 International
9 stars 4 forks source link

Feature engineering chapter (Brendan's edits) #28

Closed brendanhcullen closed 3 years ago

datalorax commented 3 years ago

Really appreciate you putting each section in a different commit. Then if we need to (which I don't expect we will) we can always cherry pick specific commits to merge, rather than all of them.

brendanhcullen commented 3 years ago

Glad that's useful! I figured it would make it easier to reference commits for individual sections, and you can always comment on any change I make to ask for clarification or request that I revert/edit it 👍

brendanhcullen commented 3 years ago

@datalorax Finished a full review. This chapter is AWESOME! 🌟 So much good stuff packed in. Most of my changes are very minor and grammatical, but please feel free to let me know anything you'd like me to revise/revert with a new commit, or of course feel free to do so yourself. Thanks!

datalorax commented 3 years ago

Awesome, thanks so much! Really appreciate it. I will review these today and let you know if I have any questions or further edits!