search

datalorax / sds-r

Repo for a draft book on social data science methods with R
https://sds.pub
Creative Commons Attribution 4.0 International
9 stars 4 forks source link

Git Chapter review #43

Closed datalorax closed 3 years ago

datalorax commented 3 years ago

Just an FYI @ohmaddi this is ready to go. There's an open PR you can add edits to if you'd like (I'm okay waiting to merge since the term hasn't started) and the preview is here.

Whenever you get around to this is fine - no pressure at all. But if you think you won't be able to get to it before the term starts then I'll probably just merge it in and we can do the edits later.

ohmaddi commented 3 years ago

@datalorax I just completed the chapter review. It is really good and super helpful. I only made some minor text edits and one html comment regarding the repo initial files (gitignore and MIT license).

Now that I read the chapter and finally understand the branching process much better (thank you), I realized I should have created a new branch for the review itself instead of making changes directly to your branch. But as I said the changes were minor. The next review should go smoothly with no mistakes.

All the changes were pushed to the remote. You only need to look at the comment and then you can go ahead and merge.

datalorax commented 3 years ago

Thanks @ohmaddi! I'm fine with you pushing directly to this branch. I'll take a look and get it merged in later today!