search

datalorax / slidex

Convert PowerPoint Slides to xaringan (remark.js) Slides
Other
290 stars 39 forks source link

Internalize utils.R functions? #13

Closed pkq closed 6 years ago

pkq commented 6 years ago

I appreciate that you documented the functions in utils.R (for people like me trying to understand the magic under the hood), but noticed they all show up in the package manual/index. Is that intentional? As you may know, individual functions can be excluded with @keywords internal. If you want it, I'll submit a PR for that. If not, feel free to close. 😄

datalorax commented 6 years ago

Yeah some of them should have the internal tag and others are missing it. I want to document all the functions but some are not documented at all yet. But they should all be internal. If you don't mind adding that tag that would be fantastic!

And thanks again for all your help. I'd be happy to add you as a contributor on the DESCRIPTION file if you'd like to add that in too.

pkq commented 6 years ago

Of course! Sounds good, I'll add another commit to #14 with my info.