datalorax / slidex

Convert PowerPoint Slides to xaringan (remark.js) Slides
Other
289 stars 39 forks source link

Images not being transferred #15

Open aegerton opened 6 years ago

aegerton commented 6 years ago

Daniel,

Thanks for a really interesting package. A couple of points:-

1.) For some reason, the Powerpoint images are not coming across into the img folder. 2.) When I bring over the Windows metafiles (.emf) manually as .jpg files and then rename them with the .emf extension in R, they work fine (but not if brought across as .emf files). 3.) The first time that I use the convert_pptx command only six slides are rendered from the .Rmd file, despite all being contained in the .Rmd script. 4.) However, after making any simple change to the .Rmd file, the full number of slides are rendered satisfactorily.

I hope this feedback is helpful.

datalorax commented 6 years ago

Thanks @aegerton. I appreciate the feedback! Would you mind sharing the powerpoint you were testing this on?

For 1), are you saying that the image files are just not there at all? That would be surprising to me and perhaps a Windows specific thing that I need to address. (this has all only really been tested on a Mac)

For 2), I was aware that .emf files were not rendering but I thought I was going to have to use Libre Office to convert them to jpg or png files. Are you saying that by just using R to rename the extension it worked? That would be great news and something I could implement very quickly! (I admit, I hadn't thought of just changing the extension.

3) sounds like it's a problem outside of slidex, but I'd be happy to take a look. The package is really just meant to write the Rmd file for you, so if that's mostly coming across then I'm not sure how to address it.

4) will likely always be the case, unfortunately, but my hope is that the package does about 80% of the work about 90% of the time.

Thank you for trying it out and for your feedback!

aegerton commented 6 years ago

Daniel, I tried it out on several .pptx files, an example of which is attached.

You are right, I am using Windows, and no image files appeared in the img sub-directory. If I go to the presentation in PowerPoint and copy the image file across to the img sub-directory, they are then rendered satisfactorily.

Furthermore, if I save the Windows meta file (.emf) with a .jpg extension in the same sub-directory and then manually change the file extension in R back to .emf, the rendering works fine.

Regarding the number of slides rendered, the Rmd file is indeed correct. However, initially only six slides are rendered for some reason. (I am a novice!) It is only when a change is made to the Rmd file that the full number of slides are rendered.

Happy to help!

datalorax commented 6 years ago

Thanks @aegerton, but unfortunately it doesn't look like the file uploaded. Could you try again?

aegerton commented 6 years ago

Apologies, Daniel. I am answering this on an iPad and struggling to attach a file. You can download the file via this link;- https://www.dropbox.com/s/8i1ymz1gat75bj9/HUL%20Introductory%20Presentation%200717a.pptx?dl=0

datalorax commented 6 years ago

Thanks @aegerton, this does indeed appear to be a Mac/Windows issue. I'll dig into it more and let you know when I've arrived on a solution. Thanks again!

aegerton commented 6 years ago

Thank you, Daniel, for coming up with such a great idea and useful package.

tungttnguyen commented 6 years ago

I can confirm that no images/photos were transferred on Windows 10 Pro. I attach a test pptx file for reproducibility

slidex_template.pptx

Can't wait to use this awesome package soon! Thanks!

Session Info

R version 3.5.1 (2018-07-02)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows >= 8 x64 (build 9200)

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] tibble_1.4.99.9004 xaringan_0.7       kableExtra_0.9.0   knitr_1.20.15     

loaded via a namespace (and not attached):
 [1] Rcpp_0.12.18      rstudioapi_0.7    xml2_1.2.0        magrittr_1.5     
 [5] hms_0.4.2.9001    munsell_0.5.0     rvest_0.3.2       viridisLite_0.3.0
 [9] colorspace_1.3-2  R6_2.2.2          rlang_0.2.2.9000  stringr_1.3.1    
[13] httr_1.3.1        tools_3.5.1       xfun_0.3          htmltools_0.3.6  
[17] fortunes_1.5-4    digest_0.6.16     rprojroot_1.3-2   crayon_1.3.4     
[21] readr_1.2.0       evaluate_0.11     rmarkdown_1.10    stringi_1.2.4    
[25] compiler_3.5.1    pillar_1.3.0.9000 scales_1.0.0.9000 backports_1.1.2  
[29] pkgconfig_2.0.2
datalorax commented 6 years ago

Thanks for confirmation! I have had to put development on hold for a bit because of other duties but hope to resume soon. I appreciate you adding the example pptx.

hackenjoe commented 5 years ago

Hi @datalorax It still not possible to use images in .pptx files on Windows. Is there a workaround available? Because each time the img subfolder of assets is empty. (I am using Win10).

datalorax commented 5 years ago

Hi @hackenjoe, I really apologize but I just have not had any time to devote to this since its initial development. So yes, this is still an issue. I will try to work on this soon but unfortunately I can't make any promises. I am unfortunately still swamped with other duties (and this is just a side project/thing I developed for fun).

christopherjwilson commented 5 years ago

This is such a great package. I came here because of the same issue, but I can see that you are still working on it. Thanks for all your hard work!

datalorax commented 5 years ago

Hi @christopherjwilson, I am definitely aware of the issue but unfortunately still haven't had a chance to work on it. 😕

fyuniv commented 4 years ago

This is really an issue that needs to be fixed (for Windows system). I am looking forward to that. Thank you!