search

datalorax / slidex

Convert PowerPoint Slides to xaringan (remark.js) Slides
Other
290 stars 39 forks source link

Added `on.exit for `sink_rmd`. #17

Closed muschellij2 closed 6 years ago

muschellij2 commented 6 years ago

Added on.exit (with a simple indentation) and a version bump to fix the problem with any errors on sink() will make sure to exit with a sink() to close the rmd connection.

datalorax commented 6 years ago

Thanks @muschellij2, If you look at the newbullets branch you'll see this is actually already there, but the function is now called write_rmd. I'm going to merge most of those changes in soon but am still working with a few tweaks. I just haven't had any time to work on this as of late. So I'm not going to merge this in at the moment, but I really appreciate your help.