search

datalorax / slidex

Convert PowerPoint Slides to xaringan (remark.js) Slides
Other
290 stars 39 forks source link

Change 'open' to use platform dependent call #8

Closed AkhilGNair closed 6 years ago

AkhilGNair commented 6 years ago

Sys.getenv("R_BROWSER") seems to give the correct open call. I think open is the Mac default, but it's xdg-open on Linux.

Reference: https://stackoverflow.com/a/43713588/4303355

Thanks for the package!

datalorax commented 6 years ago

Ah... I had no idea. Thanks! If you'd like, I'd be happy to list you as a contributor if you update the DESCRIPTION accordingly before I merge this.

datalorax commented 6 years ago

Going to merge this in now because I'm going to do a bit more work on it and don't want to run into conflicts but I'd be happy to accept a later PR to add you as a contributor if you'd like.

AkhilGNair commented 6 years ago

Thank you! No need though - just a small change :)