rendered ingress manifest has a blank line after "rules"

datalust / helm.datalust.co

Helm charts hosted on helm.datalust.co

Apache License 2.0

10 stars 16 forks source link

Closed KenWestgate closed 3 years ago

KenWestgate commented 3 years ago

There appears to be a missing left chomp - on line 31: {{ if .Values.ui.ingress.enabled }} of of https://github.com/datalust/helm.datalust.co/blob/main/charts/seq/templates/ingress.yaml

This leads to rendered manifests with a blank line after "rules"

Line 31 should read: {{- if .Values.ui.ingress.enabled }}

nblumhardt commented 3 years ago

Thank you, Ken - fixed now 👍 The fix should be out with the next maintenance release - are you blocked on this in the meantime?

KenWestgate commented 3 years ago

Excellent, thanks for the very quick fix Nicholas. There's no block so the next maintenance release will be absolutely fine thank you.