search

datalust / seq-api

HTTP API client for Seq
https://datalust.co/seq
Apache License 2.0
77 stars 21 forks source link

Consider signing released assembly #53

Closed amaechler closed 4 years ago

amaechler commented 6 years ago

When trying to build an application requiring strong-named assemblies, I get the following error when including the Seq.Api nuget package:

CSC : error CS8002: Referenced assembly 'Seq.Api, Version=4.2.2.0, Culture=neutral, PublicKeyToken=null' does not have a strong name.

due to released assembly not being signed.

nblumhardt commented 6 years ago

Hi! Thanks for the suggestion. Does StrongNamer solve this problem for you?

Best regards, Nick

amaechler commented 6 years ago

Thanks for the quick reply @nblumhardt. I wasn't aware of StrongNamer, and that would indeed work for me.

~After diving in a bit further into strong-naming assemblies, the project I'm working on might be able to simply disable signing assemblies altogether.~ We will most likely sign the assembly ourselves for the time being.

That said, it could potentially still be useful for Seq.Api to provide strongly-named assemblies for the largest possible compatibility.

amaechler commented 5 years ago

Update In the meantime, Microsoft released a open-source library guide suggesting strong-signing as well: https://docs.microsoft.com/en-us/dotnet/standard/library-guidance/strong-naming#create-strong-named-net-libraries

nblumhardt commented 5 years ago

Thanks for the follow-up. I don't think we'll have time for this in the v5 schedule; given there's a good workaround via StrongNamer my inclination is to leave this one for now - please do let us know if you end up blocked, however.

nblumhardt commented 4 years ago

This package's dependency on Tavis.UriTemplates blocks us from signing, currently; I think we may revisit this in the future, but for now I'll close this one.

Thanks again for the input, @amaechler 👍