search

datalust / seq-api

HTTP API client for Seq
https://datalust.co/seq
Apache License 2.0
77 stars 21 forks source link

Support certificate validation callbacks, proxy settings, etc. #80

Closed nblumhardt closed 4 years ago

nblumhardt commented 4 years ago

Provide a configuration callback that acts on the underlying HttpClientHandler, e.g. for certificate validation or proxy configuration.

Also adds a missing IDisposable implementation on SeqConnection - I suspect this was omitted because of an earlier design iteration where SeqClient was passed into SeqConnection and not owned by it.

Alternative to #78. CC @nmkryon

natanmejirovsky commented 4 years ago

It seems like a good option to me after the test. When we can have a package with the change?

nblumhardt commented 4 years ago

@nmkryon thanks for taking a look! The 5.1.3-dev-00126 package is on NuGet with this change now.

natanmejirovsky commented 4 years ago

Thank you!

natanmejirovsky commented 4 years ago

When it will be possible to have the release version?

nblumhardt commented 4 years ago

Hi @nmkryon - normally these builds don't bake too long; we test them in a few downstream applications, and take feedback on the dev versions, for a small change like this one we should have a release in a week or two. HTH, and Happy 2020!