search

datalust / seq-app-opsgenie

Create Opsgenie alerts in response to events or notifications in Seq
Apache License 2.0
3 stars 2 forks source link

Allow responder property to pass array or comma-delimited list #6

Closed MattMofDoom closed 3 years ago

MattMofDoom commented 3 years ago

Hi @nblumhardt ,

Following on from #5, I think this should fit the bill.

The Responder property should be able to pass an array or comma-delimited string.

Investing in DotUltimate was worthwhile for turning my musings into something more suitable 😂

Matt

nblumhardt commented 3 years ago

Looks good to me :+1:

MattMofDoom commented 3 years ago

Thanks - will run it through a test.

I'm contemplating adding one more feature - a default responders property to cover off "what do we do if no responders are matched", rather than passing none. Conscious of not overburdening the app, but I think it's worthwhile and gives us great coverage for alerts.

Think that should round out the feature set. I'll then turn my attention to extending Seq.App.EventTimeout as a model for using the new features ... It should be viable to use a single OpsGenie app instance for all timeout instances.

There are scenarios I considered such as alert failure, but those can be better covered by (for example) an Email+ instance sending to OpsGenie based on an error signal for this app, now that we expose the alert properties. In theory it could be streamlined by a "fallback app" setting but that would be a feature request at the Seq level and obviously need some consideration and design if it were even desirable.