search

datalust / seq-extensions-logging

Add centralized log collection to ASP.NET Core apps with one line of code.
https://datalust.co/seq
Apache License 2.0
84 stars 12 forks source link

Use IExternalScopeProvider for logging scopes #36

Closed davidfowl closed 3 years ago

davidfowl commented 3 years ago

No need to store a custom async local, the default logger factory can provide a scope implementation via the ISupportExternalScope and IExternalScopeProvider interfaces. See https://github.com/dotnet/runtime/blob/23919a4b58d888b92f5192576febf47b06942b2c/src/libraries/Microsoft.Extensions.Logging.EventLog/src/EventLogLoggerProvider.cs#L66 for more details and feel free to ping me (or I can send a PR if you agree 😄 )..

This automagically gets you features like https://github.com/dotnet/runtime/issues/34305 when using the default logger factory instance.

cc @nblumhardt

nblumhardt commented 3 years ago

Thanks for the note! A PR would be fantastic, if you have a chance :-)