search

datalust / seq-extensions-logging

Add centralized log collection to ASP.NET Core apps with one line of code.
https://datalust.co/seq
Apache License 2.0
84 stars 12 forks source link

Update Nuget Packages, and delete net462 because .NET Standard2 supports .NET Framework #43

Closed ArminShoeibi closed 3 years ago

ArminShoeibi commented 3 years ago

Hello, I wanted to use this package for my project that uses .NET 5 but this package use .NET Core packages v 2.1 so I updated packages. thank you in advance.

nblumhardt commented 3 years ago

Thank you, Armin. I think it's a good time to make these changes.

We've ended up with a slight problem in the versioning scheme - SemVer has forced us to break out of step with Microsoft.Extensions.Logging, and if we were strictly following it, we'd have to release these changes as 7.0 (breaking changes in a dependency).

I think what we might have to do is release this as 6.1 (targeting the net5.0 dependencies), then when .NET 6 is released, ship that support in version 6.2 of this package, and then finally, get back in sync with .NET from 7.0 onwards. :-)

ArminShoeibi commented 3 years ago

Hello, Thank you for accepting my Pull Request. Yes, I agreed. by the way, I want to contribute more to this project because I love Seq and ASP.NET Core together.

nblumhardt commented 3 years ago

Awesome, that's great to hear - thanks!