search

datalust / seq-forwarder

Local collection and reliable forwarding of log data to Seq
Apache License 2.0
57 stars 15 forks source link

Reuse a single HttpClient instance for all requests #39

Closed nblumhardt closed 6 years ago

nblumhardt commented 6 years ago

Investigating #37 - it seems we can re-use a single HttpClient for all requests, so no reason to avoid doing this.

PR moves HttpClient to the container to become a singleton.

Updates some dependencies, since we'll be testing the resulting -dev package.

nblumhardt commented 6 years ago

@danjohnso is it possible to give this version of the code a try? With a singleton HttpClient we should at least be able to rule out the multiple-HttpClient failure mode. (Fingers crossed :-))

The installer is at: https://ci.appveyor.com/project/datalust/seq-forwarder/build/artifacts

danjohnso commented 6 years ago

Deployed into our dev environment. I will update you on Tuesday as to the stability