search

datalust / seq-forwarder

Local collection and reliable forwarding of log data to Seq
Apache License 2.0
57 stars 15 forks source link

Changes to the target Seq's DNS entry is not detected #66

Closed williamb1024 closed 6 months ago

williamb1024 commented 9 months ago

If the internal HttpClient instance does not idle for a sufficiently long period of time, the DNS name for the Seq instance will never be resolved after the initial resolution.

This causes the forwarder instance to miss changes to the Seq server's IP address if the fowarder remains busy.

I suggest adding a TimeSpan named PooledConnectionLifetime field in the SeqForwarderOutputConfig. During the registration of the HttpClient instance, use the configured TimeSpan value to set the PooledConnectionLifetime property of the SocketsHttpHandler.

I would be happy to provide a pull request, if you are interested.

nblumhardt commented 9 months ago

Hi @williamb1024, thanks for the report, this sounds like a good change. We'd be happy to work through a PR if you are able to send one 👍

nblumhardt commented 6 months ago

67 addressed this