datalust / seq-logging

A Node.js client for the Seq HTTP ingestion API
Apache License 2.0
25 stars 15 forks source link

Fixed problem with logging over HTTPS #3

Closed marcinbudny closed 7 years ago

marcinbudny commented 7 years ago

Fixes the Error: Protocol "https:" not supported. Expected "http:" problem when trying to write events to Seq over HTTPS.

marcinbudny commented 7 years ago

Given the build failure, I tried to reproduce the problem on a clean machine. To mirror the build environment, I installed node ver. 4.2.2, then ran npm install -g npm which upgraded the npm version to 5.4.1. Then the npm install command resulted in following error:

0 info it worked if it ends with ok
1 verbose cli [ 'C:\\Program Files\\nodejs\\node.exe',
1 verbose cli   'C:\\[some path here]\\npm\\node_modules\\npm\\bin\\npm-cli.js',
1 verbose cli   'install' ]
2 info using npm@5.4.1
3 info using node@v4.2.2
4 verbose stack TypeError: Buffer.alloc is not a function
4 verbose stack     at Object.<anonymous> (C:\[some path here]\npm\node_modules\npm\node_modules\tar\lib\pack.js:32:20)
4 verbose stack     at Module._compile (module.js:435:26)
4 verbose stack     at Object.Module._extensions..js (module.js:442:10)
4 verbose stack     at Module.load (module.js:356:32)
4 verbose stack     at Function.Module._load (module.js:311:12)
4 verbose stack     at Module.require (module.js:366:17)
4 verbose stack     at require (module.js:385:17)
4 verbose stack     at Object.<anonymous> (C:\[some path here]\npm\node_modules\npm\node_modules\tar\lib\create.js:6:14)
4 verbose stack     at Module._compile (module.js:435:26)
4 verbose stack     at Object.Module._extensions..js (module.js:442:10)
4 verbose stack     at Module.load (module.js:356:32)
4 verbose stack     at Function.Module._load (module.js:311:12)
4 verbose stack     at Module.require (module.js:366:17)
4 verbose stack     at require (module.js:385:17)
4 verbose stack     at Object.<anonymous> (C:\[some path here]\npm\node_modules\npm\node_modules\tar\index.js:4:30)
4 verbose stack     at Module._compile (module.js:435:26)
5 verbose cwd c:\[some path here]\seq-logging-https-fix
6 verbose Windows_NT 10.0.14393
7 verbose argv "C:\\Program Files\\nodejs\\node.exe" "C:\\[some path here]\\npm\\node_modules\\npm\\bin\\npm-cli.js" "install"
8 verbose node v4.2.2
9 verbose npm  v5.4.1
10 error Buffer.alloc is not a function
11 verbose exit [ 1, true ]

It seems this problem also occurs during the build, but it is silenced. Then I ran the next build command npm test which gave me the exact error I can see in the build output:

Error: Cannot find module 'c:\[some path here]\node_modules\mocha\bin\mocha'

I think using the latest npm version with a quite old node version may be the problem here.

nblumhardt commented 7 years ago

Thank you for the PR; I'll have a look at updating the build environment for this 👍

nblumhardt commented 7 years ago

Merged, build is happy on Node 6.2.11. Thanks!