search

datalust / seq-logging

A Node.js client for the Seq HTTP ingestion API
Apache License 2.0
25 stars 15 forks source link

Add JSDoc to public methods #44

Closed rj-xy closed 3 years ago

rj-xy commented 3 years ago
  1. Add JSDocs to public methods on seq_logger.js
  2. Fix up some typing errors on index.d.ts
  3. ESLint did it's thing - I can revert these formatting changes if you wish
rj-xy commented 3 years ago

Bump :)

nblumhardt commented 3 years ago

Sorry about the slow response- will check this out today 👍

nblumhardt commented 3 years ago

LGTM!

In a small codebase like this I'm okay with the ESLint defaults :-) 👍

rj-xy commented 3 years ago

I forgot to regen the definition file, so the JSDocs are exposed :facepalm:

rj-xy commented 3 years ago

I forgot to regen the definition file, so the JSDocs are exposed facepalm

Fixup PR: https://github.com/datalust/seq-logging/pull/47