Closed Mairu closed 3 years ago
Thanks! Surprising that the JSON bug has been lurking there for six years!
The test failures are due to some flakiness we're yet to flush out when running in GitHub actions - the change looks good to me :+1:
The http
vs https
change is interesting - I've checked the documentation for request
and the options
it supports do include protocol
:
https://nodejs.org/api/http.html#http_http_request_options_callback
Wonder whether we need to dig into this further?
Thank you for that fast response.
For the protocol, the "problem" is, that you provide your own agent, and then the protocol of the agent and the request does not match. It seems that the agent ones is used in such cases.
Thanks for the follow-up. We tested this out locally, and got a hard failure early on in the sending of the request (protocol not supported), so it doesn't appear that any HTTP request was being sent in the earlier/broken version. New build should have this all sorted out now :-) .. Thanks again!