search

datalust / seq-logging

A Node.js client for the Seq HTTP ingestion API
Apache License 2.0
25 stars 15 forks source link

Improve browser bundler support #71

Closed liammclennan closed 1 year ago

liammclennan commented 1 year ago

seq-logging currently requires some client configuration (polyfills) for scenarios targeting the browser and using a bundler, like webpack or rollup.

This PR introduces a second entry for the library, seq-logging/web that avoids importing node.js modules that cause a problem with bundlers.

https://github.com/datalust/seq-logging/issues/61

u-rogel commented 1 year ago

@liammclennan I liked the dependency injection approach, then you don't need Rollup. Would you mind if I review the PR as well?

liammclennan commented 1 year ago

@u-rogel please.

liammclennan commented 1 year ago

Thanks for the review @u-rogel