search

datalust / seq-logging

A Node.js client for the Seq HTTP ingestion API
Apache License 2.0
25 stars 15 forks source link

onRemoteConfigChange #78

Open cheng93 opened 8 months ago

cheng93 commented 8 months ago

The following PR https://github.com/datalust/seq-logging/pull/64 has removed the functionality introduced by https://github.com/datalust/seq-logging/pull/23. Which potentially allows seq to control the logging level.

Was this intended?

KodrAus commented 8 months ago

Hi @cheng93 :wave: Thanks for pointing that out. That doesn't look intentional to me, so I think we should re-introduce it.

KodrAus commented 8 months ago

@cheng93 Were you previously using the dynamic level switching, or are you expecting to start using it?

cheng93 commented 8 months ago

I'm looking to start using it.

I saw that it was defined in the types. https://github.com/datalust/seq-logging/blob/dev/index.d.ts#L11 So thought it was available.

See https://github.com/datalust/winston-seq/discussions/18

liammclennan commented 8 months ago

@cheng93 this would be a nice feature for the JS clients, but it is not on our short term roadmap. We are interested in a PR.