datalust / seq-tickets

Issues, design discussions and feature roadmap for the Seq log server
https://datalust.co/seq
97 stars 5 forks source link

Clicking "Remove from Workspace" doesn't actually remove a dashboard from a workspace #2052

Closed axolmain closed 10 months ago

axolmain commented 10 months ago

Issue Clicking "Remove from Workspace" doesn't actually remove a dashboard from a workspace.

To Reproduce Steps to reproduce the behavior: *Make sure to have multiple dashboards

  1. Click the workspace selector
  2. Click the + icon and create a new workspace
  3. Open a dashboard in your new workspace
  4. Click the drop down arrow near the dashboard save button and select "Remove from Workspace"

Observed behavior The dashboard name/button hides but is is shown in the workspace when you click the + n more button.

Expected behavior The dashboard should not be selectable from the workspace which you removed it in.

Screenshots After clicking "Remove from Workspace" I see this: image

But it's still visible if I click the + n more button (I tried to remove all 5 which are hidden, but a screenshot is hard because when I click away the dashboards hide, so below I selected one) image

Environment (please complete the following information):

Additional context This Stack Overflow question poster ran into the same problem but no solution was offered to them. They also show in the official Seq documentation where this feature is said to be supported even though it's not? https://stackoverflow.com/questions/71484925/how-can-i-remove-signal-from-a-workspace-in-seq-logging-ui

nblumhardt commented 10 months ago

Thanks for the note, @axolmain.

The "+4 more" items are the four not in the current workspace. The list shows the dashboards that are in the workspace, by default, and the "+4 more" link is how other dashboards not already in the workspace are accessed.

Keen to understand more about what you're trying to achieve - is it problematic in your scenario that the non-workspace dashboards can still be accessed, for example? Thanks again!

axolmain commented 10 months ago

Of course @nblumhardt ! I'm trying to test out seq to see if I want to use it for my team so we can have a central logging server. Ideally each user would only have access to the dashboards (and logs) of the project their working on (i.e. if they're on our web team they can see the logs in the "web team" workspace, without the possibility of seeing dashboards from any other team).

Right now I have a few workspaces with a couple dashboards in each workspace. The logs are "filtered" via signals. With the free tier I know I can only have one admin user, but is it possible to add other users who can see only their team's workspaces with the premium version?

Also as a side note I'm wondering if you know if there's a way to easily find an error in the Events tab by clicking an error in the Dashboards? i.e.

  1. Have table which shows events as table (e.g. all errors WHERE MachineName = 'XYZ'
  2. Click a row to navigate to that error in the general events tab

*My current implementation for that is adding a column to the aforementioned table, containing the query a user can copy paste to the Event search bar (or use the query shortcut with the error ID if its known)

Thanks!

nblumhardt commented 10 months ago

Hi @axolmain, thanks for the update.

No, workspaces aren't a visibility boundary - Seq does have support for per-user view filters (Settings > Users > (edit) > View filter), which does limit event visibility, but this still doesn't hide things like signals and dashboards, which are always global if they're shared.

All multi-user use of Seq needs a subscription, so this might not turn out to be a useful option, if you're restricted to free products only.

On dashboards, if errors are shown in a bar chart or timeseries, clicking the bar/point should take you to a list of contributing errors over in Events. The table display style on dashboards doesn't support this, unfortunately.

Hope this all helps!

Nick

axolmain commented 10 months ago

This is all very helpful and informative, thanks @nblumhardt !

I'm sure I'll find a good way to use the user filters, Seq seems to be a great fit if I can get around that right now.

Thanks again!

Sebastian