datalust / seq-tickets

Issues, design discussions and feature roadmap for the Seq log server
https://datalust.co/seq
96 stars 5 forks source link

Dashboard: Resetting date range sets "by" to "1ms" #2202

Closed IsThatUniqueEnough closed 2 months ago

IsThatUniqueEnough commented 3 months ago

Description When hitting "RESET" in the custom date range dialog of a dashboard "by" is set to "1ms".

To Reproduce Steps to reproduce the behavior:

  1. Dashboard is set to "Last 1d" by "15m" (or any custom range)
  2. Click on 'Last 1d'
  3. Click on "Custom..."
  4. Click on "RESET"
  5. Setting is now "Last 1d" by "1ms"

Expected behavior Reset the values to reasonable defaults instead of setting "by" to "1ms". (I'm not sure how the defaults for the date range and "by" are calculated but usually my dashboards default to "1d" by "15m" and "by" is set to an interval that makes sense for the currently selected date range).

Environment

nblumhardt commented 3 months ago

Thanks, looks like we broke this when we modified custom date selection in 2024.3, we'll patch it up :+1: