search

datalust / serilog-sinks-seq

A Serilog sink that writes events to the Seq structured log server
https://datalust.co/seq
Apache License 2.0
225 stars 50 forks source link

Investigate setting a non-infinite `PooledConnectionLifetime` by default #178

Closed nblumhardt closed 2 years ago

nblumhardt commented 2 years ago

Pooled HttpClient connections (somewhat infamously :-)) have trouble responding to DNS changes; we think we might have observed one recently in https://github.com/datalust/seq-tickets/discussions/1651.

On platforms that support SocketsHttpHandler, we should strongly consider setting a non-infinite PooledConnectionLifetime if no handler is supplied by the user.

nblumhardt commented 2 years ago

@Mike-E-Angelo this change is now published in v5.1.2-dev-00229; we'll be making a 5.2 release within a month or so and rolling this in - any feedback appreciated :-)

Mike-E-angelo commented 2 years ago

Thank you very much @nblumhardt and team for your efforts. 🙏

No feedback here as of yet, as long as it works and keeps me off your forums that's all I really care about :D