Fix SeqIngestionApi not calling TryIngestAsync with ConfigureAwait(false)

datalust / serilog-sinks-seq

A Serilog sink that writes events to the Seq structured log server

https://datalust.co/seq

Apache License 2.0

239 stars 50 forks source link

Fix SeqIngestionApi not calling TryIngestAsync with ConfigureAwait(false) #215

Closed lordmilko closed 7 months ago

lordmilko commented 7 months ago

SeqIngestionApi is missing a call to ConfigureAwait(false). When writing events to a SeqAuditSink from a thread that has a synchronization context, SeqAuditSink.Emit will block the thread waiting for the HttpClient request to complete, causing a deadlock when the synchronization context tries to resume on the thread that SeqAuditSink.Emit is blocking

nblumhardt commented 7 months ago

Thanks! 👍