search

datalust / serilog-sinks-seq

A Serilog sink that writes events to the Seq structured log server
https://datalust.co/seq
Apache License 2.0
239 stars 50 forks source link

Kindly upgrade the Seq Sink to use version the latest version 4.0.0(1st June 24) of Serilog instead of 3.1.1 #226

Closed albgen closed 5 months ago

albgen commented 5 months ago

I have some strange issues like [Could not load file or assembly 'Serilog, Version=2.0.0.0, Culture=neutral, PublicKeyToken=24c2f752a8e58a10' or one of its dependencies].. This is happening after i upgrade Serilog to v 4.0.0. The problem is that the Sinks.Seq is requesting this version(AssemblyVersion 2.0.0.0) and causing that error because Serilog 4.0.0 has now an assembly version of 4.0.0.0. image

ps: not to mention that Serilog Assembly Versionin is very strange. They passed from Assembly Versionin 2.0.0.0 to 4.0.0.0 but they was not touching the file version until version 4.0.0.0

thank you

nblumhardt commented 5 months ago

Hi! This is on its way today in #224.

There's a small amount of background discussion on the assembly version unpinnning in https://github.com/serilog/serilog/issues/1996 - unfortunately, although pinning prevents some issues, there are a large class of issues it causes, so we're trying to go with the least-surprising approach from now on.

The app crash here though is most likely due to a build problem; your build process (MSBuild etc.) should be generating binding redirects - the Seq sink update will fix this one case, but it's likely unless your build generates the correct binding redirects you'll hit more issues via other libraries. HTH!

nblumhardt commented 5 months ago

Version 8.0.0 is on NuGet now :+1:

albgen commented 5 months ago

Oh i see. Thanks for updating Sinks.Seq! Have nice day