search

datalust / serilog-sinks-seq

A Serilog sink that writes events to the Seq structured log server
https://datalust.co/seq
Apache License 2.0
225 stars 50 forks source link

System.Net.Http reference #83

Closed flookami closed 7 years ago

flookami commented 7 years ago

Hi everyone, I'm going into an issue with the package System.Net.Http on my solution targeting the full framework v4.7 This (big) solution has plenty of projects including legacy Webforms web app When adding seq sink package, this leads to compiler warnings and issues, sometime not really addressed by assembly bindings.

I was wondering if the referenced nuget package System.Net.Http v4.3 had features not present in the full framework or if you could just use the one installed per default in C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework.NETFramework\v4.7\System.Net‌​.Http.dll and remove the dependency on System.Net.Http v4.3 when targeting the full framework

not to mention that including this package includes automatically the following other subdependencies that adds overhead:

  <package id="System.Security.Cryptography.Algorithms" version="4.3.0" targetFramework="net462" />
  <package id="System.Security.Cryptography.Encoding" version="4.3.0" targetFramework="net462" />
  <package id="System.Security.Cryptography.Primitives" version="4.3.0" targetFramework="net462" />
  <package id="System.Security.Cryptography.X509Certificates" version="4.3.0" targetFramework="net462" />

I think mixing ".NET Standard Nuget Framework assemblies" and full framework assemblies leads to dependency issues and should not be done

For the moment I decided to remove my Seq sink integration due to those issues, but I'm really looking forward to receiving your response! without assembly bindings solution :)

cheers

nblumhardt commented 7 years ago

Thanks for the note, @flookami - I'll look into what it might take to provide a .NET 4.7-specific target in the package to get us around this.

nblumhardt commented 7 years ago

85 implements your suggestion, thank you Michael! I'll close this but track any remaining issues in the 3.4.0 build of the package via the earlier #73 ticket.

flookami commented 7 years ago

cool! thanks a lot, we are really happy to welcome back the seq sink in our solution any sooner 👍