search

datalust / superpower

A C# parser construction toolkit with high-quality error reporting
Apache License 2.0
1.05k stars 98 forks source link

dotnet 8 upgrade? #159

Closed marklauter closed 2 months ago

marklauter commented 3 months ago

Are there any plans to upgrade SP to dotnet 8? 6 and 7 are almost OOS, and the Nuget release is still dotnet 5. If there is interest from Datalust / Nick, and it would not be a waste of my time, then I would be happy to do the work and submit a PR.

nblumhardt commented 3 months ago

Hi Mark, thanks for the offer. It looks like dev already targets net6.0, which will still be a good target for many years to come, but the tooling would benefit from an update to .NET 8 norms, and adding net8.0 to the list of explict TFMs would also be welcome, if you're keen to take a look :+1:

marklauter commented 3 months ago

Cool. I will have a look. Is there a contributer guidelines I should read first?

nblumhardt commented 2 months ago

Hi Mark,

No, there are no formal guidelines, but as a rule of thumb, aiming to keep the PR fairly minimal is the way to go: it'll be easier and quicker to review and merge if the changes are nonbreaking, incremental updates, without introducing new patterns, dependencies, etc.

Any broader changes can then be bundled up separately into later PRs after some discussion.

Hope this covers what you meant, let me know if you need a hand, though!

Best regards, Nick

marklauter commented 2 months ago

Thanks, Nick. I submitted a PR. I hope the global.json SDK change doesn't cause complications.

nblumhardt commented 2 months ago

Looks good, thanks Mark!