Initial/minimal project setup and features

[nblumhardt]

• [x] NPM package (shall we base the project setup on https://github.com/datalust/pino-seq ?)
• [x] Unit tests
• [x] SeqTransport
• [x] README
• [x] Publish from GitHub Actions
• [x] Badges (build, link to NPM)
• [ ] ...

[Apollon77]

As info what "we" (aka ioBroker) as project use from that winston library is also not that much https://github.com/ioBroker/ioBroker.js-controller/blob/master/lib/logger.js#L58-L97 does some converting stuff and config handling is on https://github.com/ioBroker/ioBroker.js-controller/blob/master/lib/logger.js#L291-L312 ... So if a new library supports that at least I'm happy :-)

[rj-xy]

I've made a start: https://github.com/xy1xy/winston-seq

[nblumhardt]

That's awesome @xy1xy - feel free to PR it up in any state of completeness :-)

[rj-xy]

@Apollon77 I've got the basic implementation up in this repo. If you have some time, could you kick the tyres? I'll do the same.

[Apollon77]

We will give it a try now ... https://github.com/ioBroker/ioBroker.js-controller/pull/1614 ... testing should start soon

[nblumhardt]

@Apollon77 how did it go? 🤞

[Apollon77]

Still waiting for the tester to respond ;-)

But @nblumhardt could you check the linked PR please if we can do it that weay ... especially the "altering "props" because we have a bit of a special usecase. Should it work that way?

[nblumhardt]

LGTM, @Apollon77 - will be good to hear how it goes :+1:

[foxriver76]

@nblumhardt Our problem is, that we want to change the loglevel of the seq transport during runtime. If we do this by overwriting the level attribute of the transport it shows no effect and the loglevel which has been passed to the constructor stays active.

Maybe you have an idea?

[nblumhardt]

@foxriver76 ah, I see! I'm not sure this has ever been explicitly considered as a feature, here; SeqTransport just extends TransportStream from winston-transport, so I assume we'll be inheriting its behavior. Might need some digging around to find out where in Winston the level filter is applied, and what we need to do to support changing it dynamically 🤔

[foxriver76]

Thanks for your fast response.

We are using other transports too, mainly DailyRotateFile and for at least DailyRotate the change of the loglevel on the fly is working. For the other ones I am personally not sure, because they are only enabled if user is explicitly configuring them but no issues are known.

Change happens on our side for every transport and is currently done just like this: https://github.com/ioBroker/ioBroker.js-controller/blob/c68f371638bea7df442ee7de07226e7cfaab8b78/packages/adapter/lib/adapter/adapter.js#L9091

[nblumhardt]

Thanks, Max. As far as I can tell, the Seq transport should inherit this. Has anyone been able to test the updated version and confirm whether the PR has fixed the issue?

[foxriver76]

Thanks, Max. As far as I can tell, the Seq transport should inherit this. Has anyone been able to test the updated version and confirm whether the PR has fixed the issue?

Do you mean our PR which introduces your module to our users? Yes, feedback is here https://github.com/ioBroker/ioBroker.js-controller/issues/1322#issuecomment-1005228960

All in all this issue unfortunately still exists.

[nblumhardt]

Thanks @foxriver76!

We've added a test to check that level changes are respected by the Seq transport:

https://github.com/datalust/winston-seq/blob/main/test/integration.test.ts#L229

This passes -- for me :-) -- can you spot any differences with how ioBroker is using the transport?

[foxriver76]

We are checking, seems to be a fault on our side. Thanks for the investigation

[foxriver76]

fixed on our side. Thanks again.

[Apollon77]

So yes, we will soon (TM) release our new version of the ioBroker main component with your library included. tests are going fine

[nblumhardt]

Excellent - thanks for closing the loop.

I think since we've "1.0"'d this library, we should close this issue :-)

All the best with your release!

[Apollon77]

Thank you very much for your support and officially maintaining this lib!