search

datamade / bga-payroll

💰 How much do your public officials make?
4 stars 4 forks source link

User email prompt/collection issue #479

Open deraj1013 opened 3 years ago

deraj1013 commented 3 years ago

A user reported an issue with the email collection prompt that I was able to duplicate in incognito mode in my browser with an email that has not been used to sign up for the database. Essentially, when the user hits a maximum allowable search, it prompts him to enter his email. He does, and then the prompt tells him to check his email for a verification message.

I was under the impression that the email information was now being handled through a cookie rather than the email verification. Let me know if I'm wrong, and if you have any idea what the problem is here. Also, if you need more information from me, let me know.

image009 image008 image007

deraj1013 commented 3 years ago

Also, let me know if this is a problem with Salsa on our end.

hancush commented 3 years ago

@deraj1013 This is the expected behavior. I will send you testing instructions that outline the full spec via email, as they contain the login for the staging site.

deraj1013 commented 3 years ago

I'll check through the instructions. The user (and I) are not getting the verification email. That's not how it's supposed to work, is it?

hancush commented 3 years ago

If there is no email, then things aren't working as expected. I will open an email thread with you and John, as we will need some budget to debug and repair the issue.

deraj1013 commented 3 years ago

Sounds good

deraj1013 commented 3 years ago

So it looks like the email came through to my account about four hours after I submitted it. It may be an issue on the end of our user rather than the system.

hancush commented 3 years ago

The same thing happened to me, when I resubmitted my email as a test! Think the message came through the next day. Picking this up now, @deraj1013.

hancush commented 3 years ago

TODO: Swap in SendGrid creds prior to launch.

hancush commented 3 years ago

For posterity, this was mostly addressed by https://github.com/datamade/django-salsa-auth/pull/9.

hancush commented 3 years ago

Update: We've switched over to SendGrid for the launch.