Correctly filter for salaries in a given year, handles #539

hancush commented 3 years ago

Description

Similarly to #536, this PR addresses a bug that omitted people from indexing if they held their job in a prior year, by selecting people to index based on the vintage of their salary, rather than their job.

Testing instructions

Tested locally by having 2019 data in my database, then running docker-compose run --rm app python manage.py build_solr_index --entity-types people --reporting_year 2019 --recreate and finally confirming that the correct number of people were indexed for a sample of employers.
Once this is approved, I'll reindex the staging site with the same command (omitting reporting year), and we should spot check the examples in #539 to confirm they appear in the search index.

hancush commented 3 years ago

P.s., I also did a quick search of the code base for job__vintage to check for other places where this bug might crop up. No results!

smcalilly commented 3 years ago

P.s., I also did a quick search of the code base for job__vintage to check for other places where this bug might crop up. No results!

was gonna ask if this might happen in the data download we added, but i think this answers that.

hancush commented 3 years ago

Good thought, @smcalilly! You're using the get_salaries method in the export, which helpfully queries Salary directly. One of the handful of good decisions I made, I guess. 😂

https://github.com/datamade/bga-payroll/blob/7880eca4a46b03922fd0f695e993ef1e0613bb7d/payroll/models.py#L184-L195

datamade / bga-payroll

Correctly filter for salaries in a given year, handles #539 #540

Description

Testing instructions